Conversation
|
@qoega Sorry, but it's totally wrong. |
|
And you forgot to assign yourself and mark the pull request as "Approved" (to indicate that you have reviewed it). |
|
If you can write makefiles, you can help... |
|
This increased our internal build times significantly, to the point where they started breaching 3h timeout. Previous build of v20.7 took just 1h14m. On a system with 2 x Xeon E5-2630 v3 (32 logical CPUs in total) I see:
Memory usage between two builds, taken at 1m interval: Seems like there's also some other regression in terms of compilation times: Either way, I don't think Clickhouse build should make assumptions about CPU topology:
From the log you linked it seems that your build system doesn't have enough memory and compiler/linker gets killed when many copies run at the same time ( |
|
@bobrik This is just a temporary change to allow CI to run before we optimize the build. PS. We don't control the amount of memory on CI servers. I think, we should assume that they have 128 GiB. |

Changelog category (leave one):
Don't use all hyperthreading cores.
See https://clickhouse-builds.s3.yandex.net/14333/ac5877e601714450a369062abbf80f84485bc6f5/clickhouse_build_check/build_log_761737419_1598985376.txt