Better check for tuple size in SSD cache complex key external dictionaries#14313
Merged
alexey-milovidov merged 4 commits intomasterfrom Sep 2, 2020
Merged
Better check for tuple size in SSD cache complex key external dictionaries#14313alexey-milovidov merged 4 commits intomasterfrom
alexey-milovidov merged 4 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-bugfix
alexey-milovidov
changed the title
Member
Author
|
CC @nikvas0 |
| assert(key_columns.size() == key_types.size()); | ||
| assert(key_columns.size() == dict_struct.key->size()); | ||
|
|
||
| dict_struct.validateKeyTypes(key_types); |
Member
Author
There was a problem hiding this comment.
Only two calls to validateKeyTypes matter.
Everything else is just "defensive programming".
| const auto & structure = dict->getStructure(); | ||
| assert(structure.key); | ||
| size_t key_size = structure.key->size(); | ||
| if (key_columns.size() != key_size) |
Member
There was a problem hiding this comment.
It seems it doesn't work for polygon dictionaries because they have Array(Array(Array(Array(Float64)))) as key of size 1. And third argument in dictGet is tuple(x, y) of size 2.
Member
Author
|
Ok. I will remove the check from functions. |
This was referenced Sep 2, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 2, 2020
…plex key external dictionaries
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 2, 2020
…plex key external dictionaries
robot-clickhouse
pushed a commit
that referenced
this pull request
Sep 2, 2020
…plex key external dictionaries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Better check for tuple size in SSD cache complex key external dictionaries. This fixes #13981.
Detailed description / Documentation draft:
See https://clickhouse-test-reports.s3.yandex.net/14232/b38c5a844c4178db8f201cf10fb8ef08f769fdff/fuzzer/server.log
No test because the possibility of specifying path in SSD cache dictionary will be removed soon.