Skip to content

Fix crash in SchemaAllowedHandler.#14267

Merged
alesapin merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-schema-allowed-handler
Aug 31, 2020
Merged

Fix crash in SchemaAllowedHandler.#14267
alesapin merged 1 commit intoClickHouse:masterfrom
vitlibar:fix-schema-allowed-handler

Conversation

@vitlibar
Copy link
Copy Markdown
Member

@vitlibar vitlibar commented Aug 31, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category:

  • Bug Fix

Changelog entry:
Fix segfault in clickhouse-odbc-bridge during schema fetch from some external sources. This PR fixes #13861

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 31, 2020
@alesapin alesapin self-assigned this Aug 31, 2020
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like it's not easy to add a test because for some reason it works in our cases (MySQL, Sqlite, PostgreSQL). And the only known case is Oracle which has proprietary docker images.

@alesapin
Copy link
Copy Markdown
Member

Tests ok

@alesapin alesapin merged commit c0963f7 into ClickHouse:master Aug 31, 2020
vitlibar pushed a commit that referenced this pull request Sep 1, 2020
Backport #14267 to 20.5: Fix crash in SchemaAllowedHandler.
vitlibar pushed a commit that referenced this pull request Sep 1, 2020
Backport #14267 to 20.8: Fix crash in SchemaAllowedHandler.
vitlibar pushed a commit that referenced this pull request Sep 1, 2020
Backport #14267 to 20.7: Fix crash in SchemaAllowedHandler.
vitlibar pushed a commit that referenced this pull request Sep 1, 2020
Backport #14267 to 20.6: Fix crash in SchemaAllowedHandler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dictionary over ODBC is broken after v20.4.7.67

3 participants