Refactoring: rename types to allow change bigint library#14219
Merged
4ertus2 merged 6 commits intoClickHouse:masterfrom Sep 1, 2020
Merged
Refactoring: rename types to allow change bigint library#142194ertus2 merged 6 commits intoClickHouse:masterfrom
4ertus2 merged 6 commits intoClickHouse:masterfrom
Conversation
robot-clickhouse
added
the
pr-not-for-changelog
Contributor
Author
|
Fuzzer error: Cannot reproduce fuzzer error locally. |
Contributor
This query gets the "connection refused" from the start, so what failed is probably the previous query. Not sure how to make this more convenient, maybe fail fast on EOF (error code 32). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Remove 'b' prefix from 'bUint256' and 'bInt256' to allow change big ints library. Rename UInt256 from UInt128.h to DummyUInt256.
Note: it's not easy to raname UInt128 too cause of macros in dictionaries.