Skip to content

fix issue #14202#14203

Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
donge:master
Aug 31, 2020
Merged

fix issue #14202#14203
alexey-milovidov merged 2 commits intoClickHouse:masterfrom
donge:master

Conversation

@donge
Copy link
Copy Markdown
Contributor

@donge donge commented Aug 28, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix crash when INERT INTO Kafka engine table from an empty result set with a subquery.
...

Detailed description / Documentation draft:

...

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

Information about CI checks: https://clickhouse.tech/docs/en/development/continuous-integration/

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 28, 2020
@filimonov
Copy link
Copy Markdown
Contributor

Thank you, it looks good.
Can you also try to create a test for it?

See

@donge
Copy link
Copy Markdown
Contributor Author

donge commented Aug 28, 2020

Thank you, it looks good.
Can you also try to create a test for it?

See

Sure, thanks for the reminder.

@donge
Copy link
Copy Markdown
Contributor Author

donge commented Aug 31, 2020

Just get integration test running. not easy for new guy.
will write a case

.Set up TSKV
Set up JSONCompactEachRowWithNamesAndTypes
Set up JSONEachRow
Set up Regexp
Set up TSVWithNames
Set up CSVWithNames
Set up CapnProto
Set up RowBinary
Set up MsgPack
Set up JSONCompactEachRow
Set up Protobuf
Set up RowBinaryWithNamesAndTypes
Set up TSVWithNamesAndTypes
Set up TSV
Set up Values
Set up CSV
Set up ORC
Set up Native
Checking TSKV
Checking JSONCompactEachRowWithNamesAndTypes
Checking JSONEachRow
Checking Regexp
Checking TSVWithNames
Checking CSVWithNames
Checking CapnProto
Checking RowBinary
Checking MsgPack
Checking JSONCompactEachRow
Checking Protobuf
Checking RowBinaryWithNamesAndTypes
Checking TSVWithNamesAndTypes
Checking TSV
Checking Values
Checking CSV
Checking ORC
Checking Native
...../usr/local/lib/python2.7/dist-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
Pausing rootteststoragekafka_kafka1_1 ... done
/usr/local/lib/python2.7/dist-packages/requests/__init__.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
Unpausing rootteststoragekafka_kafka1_1 ... done
......Produced 20 messages for topic pb
Produced 1 messages for topic pb
Produced 29 messages for topic pb
....

@donge
Copy link
Copy Markdown
Contributor Author

donge commented Aug 31, 2020

test case for this issue is verified by adding the script, please comment. @filimonov

Copy link
Copy Markdown
Contributor

@filimonov filimonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not easy for new guy.

I know that pain... But you did it! 👍

Everything looks good. Thank you!

P.S. unbundled failure is non-relevant (#14257)

@alexey-milovidov alexey-milovidov merged commit f5a38fa into ClickHouse:master Aug 31, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 31, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 31, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 31, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 31, 2020
Akazz pushed a commit that referenced this pull request Aug 31, 2020
robot-clickhouse pushed a commit that referenced this pull request Aug 31, 2020
alexey-milovidov added a commit that referenced this pull request Sep 2, 2020
alexey-milovidov added a commit that referenced this pull request Sep 4, 2020
alexey-milovidov added a commit that referenced this pull request Sep 4, 2020
alexey-milovidov added a commit that referenced this pull request Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants