Skip to content

Try fix IfAggCombinator with NullAggCombinator#13964

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
zhang2014:fix/agg_combinator
Aug 26, 2020
Merged

Try fix IfAggCombinator with NullAggCombinator#13964
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
zhang2014:fix/agg_combinator

Conversation

@zhang2014
Copy link
Copy Markdown
Contributor

@zhang2014 zhang2014 commented Aug 22, 2020 •
edited by alexey-milovidov
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Conditional aggregate functions (for example: avgIf, sumIf, maxIf) should return NULL when miss rows and use nullable arguments

Detailed description / Documentation draft:

-- Value nullable
SELECT anyIf(CAST(number, 'Nullable(UInt8)'), number = 3) AS a, toTypeName(a) FROM numbers(2);
-- Value and condition nullable
SELECT anyIf(number, number = 3) AS a, toTypeName(a) FROM (SELECT CAST(number, 'Nullable(UInt8)') AS number FROM numbers(2));
-- Condition nullable
SELECT anyIf(CAST(number, 'UInt8'), number = 3) AS a, toTypeName(a) FROM (SELECT CAST(number, 'Nullable(UInt8)') AS number FROM numbers(2));

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 22, 2020
@zhang2014
Copy link
Copy Markdown
Contributor Author

zhang2014 commented Aug 25, 2020

Performance — 3 errors, 3 too long, 7 faster, 10 slower, 679 unstable unrelated this PR.

@zhang2014
Copy link
Copy Markdown
Contributor Author

zhang2014 commented Aug 25, 2020

Ping...

@alexey-milovidov alexey-milovidov self-assigned this Aug 25, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented Aug 25, 2020

Changelog entry does not state what bug was present and what was changed.

I will edit by myself...

@zhang2014
Copy link
Copy Markdown
Contributor Author

zhang2014 commented Aug 26, 2020

Changelog entry does not state what bug was present and what was changed.

I will edit by myself...

Done.

@alexey-milovidov alexey-milovidov merged commit f6f8dc9 into ClickHouse:master Aug 26, 2020
@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-bugfix Pull request with bugfix, not backported by default labels Aug 26, 2020
@zlobober zlobober mentioned this pull request Oct 31, 2020
Closed
@KochetovNicolai KochetovNicolai mentioned this pull request Nov 2, 2020
Merged
@KochetovNicolai KochetovNicolai mentioned this pull request Nov 15, 2020
Closed
KochetovNicolai added a commit that referenced this pull request Nov 15, 2020
@KochetovNicolai
Revert "Merge pull request #13964 from zhang2014/fix/agg_combinator"
ae55fd0 
This reverts commit f6f8dc9, reversing
changes made to 57af010.
KochetovNicolai added a commit that referenced this pull request Nov 15, 2020
@KochetovNicolai
Revert "Merge pull request #13964 from zhang2014/fix/agg_combinator"
72e635a 
This reverts commit f6f8dc9, reversing
changes made to 57af010.
KochetovNicolai added a commit that referenced this pull request Nov 15, 2020
@KochetovNicolai
Revert "Merge pull request #13964 from zhang2014/fix/agg_combinator"
49b4c52 
This reverts commit f6f8dc9, reversing
changes made to 57af010.
@alexey-milovidov alexey-milovidov mentioned this pull request Jan 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhang2014 @alexey-milovidov @amosbird @robot-clickhouse