Skip to content

Fix wrong error for long queries.#13928

Merged
alexey-milovidov merged 1 commit intomasterfrom
wring-error-for-too-long-query
Aug 21, 2020
Merged

Fix wrong error for long queries.#13928
alexey-milovidov merged 1 commit intomasterfrom
wring-error-for-too-long-query

Conversation

@KochetovNicolai
Copy link
Copy Markdown
Member

@KochetovNicolai KochetovNicolai commented Aug 20, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix wrong error for long queries. It was possible to get syntax error other than Max query size exceeded for correct query.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Aug 20, 2020
@alexey-milovidov alexey-milovidov self-assigned this Aug 20, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

TSan report - is it fixed in #13624 ? @nikitamikhaylov

@alexey-milovidov alexey-milovidov merged commit 55ac192 into master Aug 21, 2020
@alexey-milovidov alexey-milovidov deleted the wring-error-for-too-long-query branch August 21, 2020 10:18
@nikitamikhaylov
Copy link
Copy Markdown
Member

TSan report - is it fixed in #13624 ? @nikitamikhaylov

Yes.

@robot-clickhouse robot-clickhouse added pr-improvement Pull request with some product improvements and removed pr-bugfix Pull request with bugfix, not backported by default labels Aug 21, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

It's not a bugfix.

KochetovNicolai added a commit that referenced this pull request Aug 31, 2020
Backport #13928 to 20.6: Fix wrong error for long queries.
KochetovNicolai added a commit that referenced this pull request Aug 31, 2020
Backport #13928 to 20.7: Fix wrong error for long queries.
KochetovNicolai added a commit that referenced this pull request Aug 31, 2020
Backport #13928 to 20.5: Fix wrong error for long queries.
KochetovNicolai pushed a commit that referenced this pull request Aug 31, 2020
Fix wrong error for long queries.

(cherry picked from commit 55ac192)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants