Fix 00956_sensitive_data_masking flackiness#13867
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Aug 19, 2020
Merged
Fix 00956_sensitive_data_masking flackiness#13867alexey-milovidov merged 1 commit intoClickHouse:masterfrom
alexey-milovidov merged 1 commit intoClickHouse:masterfrom
Conversation
00956_sensitive_data_masking is still flacky even after ClickHouse#13748 [1]. [1]: https://clickhouse-test-reports.s3.yandex.net/10373/348ef1256ea8fb8f61109c33bbdd28daf46bdc8e/functional_stateless_tests_(debug).html#fail1 The problem is that it uses the following pattern: clickhouse-client -q ... & # run some query in background clickhouse-client -q 'show processlist' > log grep background-query log But there is no guarantee that the query in background will be executed before `show processlist`: 2020.08.18 02:52:47.916386 [ 26788 ] {98c36d38-f710-4dfb-af8f-61906abc163c} <Debug> executeQuery: (from [::1]:51650) SHOW PROCESSLIST ... 2020.08.18 02:52:47.926854 [ 26756 ] {086c64fa-713b-4f8c-b702-23bfea10a49c} <Debug> executeQuery: (from [::1]:51652) select count() from system.numbers where ignore('find_me_[hidden]')=0 and ignore('fwerkh_that_magic_string_make_me_unique') = 0 FORMAT Null Fix the test by waiting until the query in backgroud will start, and use limited numbers + sleepEachRow over system.numbers to reduce CPU usage.
robot-clickhouse
added
the
pr-not-for-changelog
This was referenced Aug 18, 2020
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
00956_sensitive_data_masking is still flacky even after #13748 1
The problem is that it uses the following pattern:
But there is no guarantee that the query in background will be executed before
show processlist:Fix the test by waiting until the query in backgroud will start, and use
limited numbers + sleepEachRow over system.numbers to reduce CPU usage.