Merged
Conversation
robot-clickhouse
added
pr-not-for-changelog
Member
Author
|
@tavplubix The reason is different. |
Member
Author
|
But DROP/RENAME in DatabaseAtomic should not drop caches. |
Member
Author
Member
Author
|
Now it's obvious why it happens in test runs with DatabaseAtomic! |
Member
Author
Fixed in #13743 |
Member
Author
Fixed in #13746 |
Member
Author
New issue, reported. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fix race condition in the annoying
test_fix_extra_seek_on_compressed_cache. The test was added here: #4913.I just found one possible reason for race condition but I'm not sure that the real reason of test failure was fixed.
Also I have found and removed
sleep 1in test - an obvious antipattern (99% of casessleepcannot workaround race conditions).It's just a bad test, no bug exists.