cache-dictionary flap#13624
Merged
nikitamikhaylov merged 13 commits intoClickHouse:masterfrom Aug 20, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
nikitamikhaylov
force-pushed
the
cache-dictionary-bugfix
branch
2 times, most recently
from
3113409 to
4c89fb8
Compare
Member
Author
|
Fuzzer error reported here #13917 |
abyss7
approved these changes
Aug 20, 2020
This was referenced Aug 20, 2020
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 24, 2020
cache-dictionary flap (cherry picked from commit 8f1ba52)
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 24, 2020
…4c0b6ae69a4ba250e23d1233fe5b6 Cherry pick #13624 to 20.6: cache-dictionary flap
nikitamikhaylov
added a commit
that referenced
this pull request
Aug 24, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 24, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 24, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Aug 26, 2020
Backport #13624 to 20.6: cache-dictionary flap
alexey-milovidov
added a commit
that referenced
this pull request
Aug 26, 2020
Backport #13624 to 20.7: cache-dictionary flap
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 28, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 28, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Aug 28, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the behaviour when sometimes cache-dictionary returned default value instead of present value from source.
Detailed description / Documentation draft:
It happens during loading the ids (for example at first query with empty cache) when multiple requested ids glue together to a batch. I decided to delete this code at all, because there are some other non-obviousness, such as exception handling.
The stateful test (dictionary on top of Metrika dataset) will be added sooner. I've noticed, that external dictionaries with ClickHouse as a source are very slow.