Skip to content

specific ReplicatedMergeTree settings#13573

Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
amosbird:rms
Sep 20, 2020
Merged

specific ReplicatedMergeTree settings#13573
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
amosbird:rms

Conversation

@amosbird
Copy link
Copy Markdown
Collaborator

@amosbird amosbird commented Aug 10, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Allow user to specify settings for ReplicatedMergeTree* storage in <replicated_merge_tree> section of config file. It works similarly to <merge_tree> section. For ReplicatedMergeTree* storages settings from <merge_tree> and <replicated_merge_tree> are applied together, but settings from <replicated_merge_tree> has higher priority. Added system.replicated_merge_tree_settings table.

There are some settings which are useful defaults for replicated tables but don't make sense for normal tables, and using merge_tree settings will complicate system tables.

Detailed description / Documentation draft:

Document has been updated.

@robot-clickhouse robot-clickhouse added doc-alert pr-feature Pull request with new product feature labels Aug 10, 2020
@abyss7 abyss7 self-assigned this Aug 11, 2020
@abyss7 abyss7 self-requested a review August 11, 2020 10:34
Copy link
Copy Markdown
Contributor

@abyss7 abyss7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a simple test, please? To check that new settings work and really have higher priority.

@amosbird
Copy link
Copy Markdown
Collaborator Author

Tests are added but not verified locally (I don't have docker right now). Let's see if I can get it right ...

@amosbird amosbird requested a review from abyss7 September 19, 2020 11:08
@alexey-milovidov alexey-milovidov merged commit 3e0509a into ClickHouse:master Sep 20, 2020
annvsh added a commit to annvsh/ClickHouse that referenced this pull request Oct 17, 2020
BayoNet added a commit that referenced this pull request Nov 8, 2020
…16110)

* #13573

* #9278

* Fixed

* Fixed

* Fixed link

* Update docs/en/sql-reference/dictionaries/external-dictionaries/external-dicts-dict-polygon.md

* Update docs/en/sql-reference/dictionaries/external-dictionaries/external-dicts-dict-polygon.md

Co-authored-by: BayoNet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-feature Pull request with new product feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants