Deadlock in textlog#13386
Merged
nikitamikhaylov merged 4 commits intoClickHouse:masterfrom Aug 6, 2020
Merged
Conversation
nikitamikhaylov
added
the
pr-bugfix
Member
Author
|
@akuzm It is a part of previous PR to backport it to stable branches. |
akuzm
reviewed
Aug 5, 2020
base/loggers/OwnSplitChannel.cpp
Outdated
| text_log_locked = text_log.lock(); | ||
| } | ||
| if (text_log_locked) | ||
| text_log_locked->add(elem); |
akuzm
approved these changes
Aug 5, 2020
This was referenced Aug 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 6, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 6, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Aug 6, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Aug 24, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Aug 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed the deadlock in textlog. It is a part of #12339. This fixes #12325
Detailed description / Documentation draft:
Mutex is needed only to get a shared_ptr from weak_ptr concurrently.