Skip to content

BayesAB test#13073

Merged
alexey-milovidov merged 7 commits intoClickHouse:masterfrom
nikitamikhaylov:rewrite-tests
Jul 30, 2020
Merged

BayesAB test#13073
alexey-milovidov merged 7 commits intoClickHouse:masterfrom
nikitamikhaylov:rewrite-tests

Conversation

@nikitamikhaylov
Copy link
Copy Markdown
Member

@nikitamikhaylov nikitamikhaylov commented Jul 29, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Rewrote Function tests to gtest. Removed useless includes from tests.

@robot-clickhouse robot-clickhouse added the pr-build Pull request with build/testing/packaging improvement label Jul 29, 2020
@nikitamikhaylov
Copy link
Copy Markdown
Member Author

I've noticed, that compilation time increased. I think it is because we use ccache, and in this PR we have to recompile many files, but there maybe another reason.
I removed only headers, that are not directly used in files.

@nikitamikhaylov nikitamikhaylov marked this pull request as ready for review July 30, 2020 10:35
@alexey-milovidov alexey-milovidov self-assigned this Jul 30, 2020
@alexey-milovidov alexey-milovidov merged commit 74edcfb into ClickHouse:master Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-build Pull request with build/testing/packaging improvement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants