Conversation
|
@azat I have already forgotten why do we limit threads here. |
|
Perf test? (reading small amount of data from a table with large amount of parts) |
|
Sure |
It had been added in #11114 Quote from the comment to the patch from that PR:
Yes, since there is no more deprecated streams (non-processors) in this code.
@alexey-milovidov FWIW there is a test for this |
| @@ -0,0 +1,3 @@ | |||
| <test> | |||
| <query>select sum(number) from remote('127.0.0.{{1|2}}', numbers_mt(1000000000)) group by bitAnd(number, 1)</query> | |||
There was a problem hiding this comment.
Hm, not sure that this query covers that case, since this reads lots of rows and also it uses numbers_mt
There was a problem hiding this comment.
Right in this case the number of threads was limited to 1.
|
@azat tests are ok. Waiting for perftests now. |
Nope, LGTM |
Remove thread limiting. (cherry picked from commit 1f2390b)
Remove thread limiting. (cherry picked from commit 1f2390b)
Remove thread limiting. (cherry picked from commit 1f2390b)
Remove thread limiting. (cherry picked from commit 1f2390b)
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unnecessary limiting for the number of threads for selects from local replica.