Fix ClickHouseDictionarySource wrong access check#12756
Merged
alexey-milovidov merged 4 commits intoClickHouse:masterfrom Aug 26, 2020
Merged
Fix ClickHouseDictionarySource wrong access check#12756alexey-milovidov merged 4 commits intoClickHouse:masterfrom
alexey-milovidov merged 4 commits intoClickHouse:masterfrom
Conversation
Contributor
Author
|
fixes #12614 |
robot-clickhouse
added
the
pr-bugfix
Member
|
Please, add a testcase from the issue. |
Contributor
Author
ok |
alexey-milovidov
approved these changes
Aug 26, 2020
This was referenced Aug 26, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 26, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 26, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 26, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Aug 26, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Aug 28, 2020
Backport #12756 to 20.7: Fix ClickHouseDictionarySource wrong access check
alexey-milovidov
added a commit
that referenced
this pull request
Aug 31, 2020
Backport #12756 to 20.5: Fix ClickHouseDictionarySource wrong access check
alexey-milovidov
added a commit
that referenced
this pull request
Aug 31, 2020
Backport #12756 to 20.6: Fix ClickHouseDictionarySource wrong access check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Removed wrong auth access check when using ClickHouseDictionarySource to query remote tables.