Fix memory tracking for input_format_parallel_parsing#12672
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom Jul 24, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
Member
Author
Fails in upstream too |
Member
Author
|
Will rebase against pre #12418 |
azat
force-pushed
the
input_format_parallel_parsing-memory-tracking-fix
branch
from
65e0dab to
91c1e2f
Compare
Member
Author
This won't help I guess, since the PR is applied on top of the upstream/master, so first the original issue should be addressed |
azat
force-pushed
the
input_format_parallel_parsing-memory-tracking-fix
branch
from
91c1e2f to
a5885b4
Compare
alexey-milovidov
approved these changes
Jul 23, 2020
Member
|
LGTM, but what's about integration test? |
Member
Author
Does related, fixed (pops up after removing |
This was referenced Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
This was referenced Jul 27, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12672 to 20.5: Fix memory tracking for input_format_parallel_parsing
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12672 to 20.6: Fix memory tracking for input_format_parallel_parsing
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12672 to 20.4: Fix memory tracking for input_format_parallel_parsing
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jul 27, 2020
Backport #12672 to 20.3: Fix memory tracking for input_format_parallel_parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix memory tracking for input_format_parallel_parsing (by attaching thread to group)
This PR includes:
Fixes: #12583
input_format_parallel_parsingintroduced in: #6553Details
HEAD: