Remove sort description from streams#12613
Merged
KochetovNicolai merged 4 commits intomasterfrom Jul 22, 2020
Merged
Conversation
KochetovNicolai
added
pr-bugfix
|
|
||
| if (deduplicate) | ||
| merged_stream = std::make_shared<DistinctSortedBlockInputStream>(merged_stream, SizeLimits(), 0 /*limit_hint*/, Names()); | ||
| merged_stream = std::make_shared<DistinctSortedBlockInputStream>(merged_stream, sort_description, SizeLimits(), 0 /*limit_hint*/, Names()); |
Member
There was a problem hiding this comment.
Let's rewrite it to processors and remove DistinctSortedBlockInputStream in next PR?
alexey-milovidov
approved these changes
Jul 21, 2020
Member
|
OUTPUT_IS_NOT_SORTED can be removed from ErrorCodes.cpp too. |
Member
Author
|
Yandex third-party checks is broken because of changes in interface. Shouldn't merge yet. |
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 22, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jul 23, 2020
This was referenced Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 27, 2020
This was referenced Jul 27, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jul 28, 2020
KochetovNicolai
added a commit
that referenced
this pull request
Jul 28, 2020
) * Remove SortDescription from IBlockInputStream. * Added test. * Fix style. * Remove unused error code. Co-authored-by: Nikolai Kochetov <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]>
KochetovNicolai
pushed a commit
that referenced
this pull request
Jul 28, 2020
robot-clickhouse
pushed a commit
that referenced
this pull request
Jul 28, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jul 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix error
Output of TreeExecutor is not sortedforOPTIMIZE DEDUPLICATE. Fixes #11572