Abort on std::logic_error in debug builds#12522
Merged
Conversation
This helps notice them in tests, same as assert() and LOGICAL_ERROR.
robot-clickhouse
added
the
pr-not-for-changelog
src/Server/TCPHandler.cpp
Outdated
| // Server should die on std logic errors in debug, like with assert() | ||
| // or ErrorCodes::LOGICAL_ERROR. This helps catch these errors in | ||
| // tests. | ||
| assert(false); |
Contributor
Author
There was a problem hiding this comment.
I only want it in a debug build, so assert is more convenient.
nikitamikhaylov
approved these changes
Jul 15, 2020
Contributor
Author
sql_fuzzy.pl finds an assertion right away |
Contributor
Author
|
Looks like it's not related to the changes. |
This was referenced Jul 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps notice them in tests, same as assert() and LOGICAL_ERROR.
Changelog category (leave one):