Skip to content

Fix trash from RabbitMQ#12448

Merged
alexey-milovidov merged 3 commits intomasterfrom
fix-trash-rabbitmq
Jul 13, 2020
Merged

Fix trash from RabbitMQ#12448
alexey-milovidov merged 3 commits intomasterfrom
fix-trash-rabbitmq

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jul 13, 2020 •
edited
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

CMakeLists for AMQP-cpp library turned our build to complete disaster.

CC @alesapin
CC @azat Look at the warnings from Arrow.

@robot-clickhouse robot-clickhouse added submodule changed At least one submodule changed in this PR. pr-not-for-changelog This PR should not be mentioned in the changelog labels Jul 13, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 13, 2020 

grep -F '"command":' compile_commands.json | grep -v -P ' -c .+?/contrib/' | grep -o -P ' (-Wno-\S+|-w )' | sort | uniq -c | sort -rn | awk '{ if ($1 >= 1000) print $2 }' | sort

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 13, 2020

Sandbox is totally broken:

2020-07-13 04:19:44
Unhandled exception: Traceback (most recent call last):
  File "sandbox/bin/executor.py", line 1043, in _execute
    self.task.on_execute()
  File "sandbox/projects/clickhouse/BaseOnCommitTask/base.py", line 295, in on_execute
    state, description, url = self.process(self.commit, repo, pull_request)
  File "sandbox/projects/clickhouse/BaseOnCommitTask/test_task.py", line 93, in process
    s3_path_prefix + "/" + os.path.basename(raw_log_path))
  File "sandbox/projects/clickhouse/util/s3_helper.py", line 75, in upload_test_report_to_s3
    return self._upload_file_to_s3('clickhouse-test-reports', file_path, s3_path)
  File "sandbox/projects/clickhouse/util/s3_helper.py", line 70, in _upload_file_to_s3
    self.client.upload_file(file_path, bucket_name, s3_path, ExtraArgs=metadata)
  File "contrib/python/boto3/boto3/s3/inject.py", line 131, in upload_file
    extra_args=ExtraArgs, callback=Callback)
  File "contrib/python/boto3/boto3/s3/transfer.py", line 287, in upload_file
    filename, '/'.join([bucket, key]), e))
S3UploadFailedError: Failed to upload ./ClickHouse/utils/check-style/output.txt to clickhouse-test-reports/12448/8f2055b0a019add57278b48cfd7be3384de39d44/style_check/output.txt: An error occurred (ServiceTotalSizeQuotaExceeded) when calling the PutObject operation: You have attempted to exceed the quota for your service on total size of all objects in your buckets. Contact our support to change quotas or remove some objects from your buckets.

@alexey-milovidov alexey-milovidov mentioned this pull request Jul 13, 2020
Closed
@azat
Copy link
Copy Markdown
Member

azat commented Jul 13, 2020

CC @azat Look at the warnings from Arrow.

Ok

alesapin
alesapin reviewed Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@alesapin alesapin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the release build.

src/Storages/RabbitMQ/ReadBufferFromRabbitMQConsumer.cpp
local_exchange_declared = false;
LOG_ERROR(log, "Failed to declare {} exchange: {}", exchange_type, message);
});
AMQP::Table binding_arguments;
Copy link
Copy Markdown
Member

@alesapin alesapin Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added scope just to avoid capturing a lot of variables in lambda?

Copy link
Copy Markdown
Member Author

@alexey-milovidov alexey-milovidov Jul 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Wshadow

@azat
Copy link
Copy Markdown
Member

azat commented Jul 13, 2020

Need to fix the release build.

These are -Wdeprecated from arrow, to fix them I need some bits from this PR (s/PUBLIC/PRIVATE/ + other rabbit mq bits), so I will pick then and fix deprecated API usage for arrow on top of it, and submit it as a separate PR

Or I can just send a patch on top of this PR here, @alexey-milovidov ?

@alexey-milovidov
Copy link
Copy Markdown
Member Author

alexey-milovidov commented Jul 13, 2020

The most convenient it to create a new branch, then pull all commits from this PR, then add more commits.

@azat azat mentioned this pull request Jul 13, 2020
Merged
@azat
Copy link
Copy Markdown
Member

azat commented Jul 13, 2020

The most convenient it to create a new branch, then pull all commits from this PR, then add more commits.

@alexey-milovidov #12477

@alexey-milovidov alexey-milovidov merged commit 1893d89 into master Jul 13, 2020
@alexey-milovidov alexey-milovidov deleted the fix-trash-rabbitmq branch July 13, 2020 22:11
@alexey-milovidov alexey-milovidov self-assigned this Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alesapin alesapin alesapin left review comments

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexey-milovidov @azat @alesapin @robot-clickhouse