Saturate negative unix timestamp to zero instead of overflow#12443
Saturate negative unix timestamp to zero instead of overflow#12443alexey-milovidov merged 3 commits intomasterfrom
Conversation
robot-clickhouse
added
the
pr-improvement
|
@akuzm Performance test showed "2 faster, 20 slower" in queries without related code paths. |
False claim, the check was not restarted, CC @exprmntr. |
|
Ok, probably it is because I did not merge with master and performance of master was improved. |
It's more complicated -- it choose the master for comparison that is newer than the master it was merged to before build, because the perf test task cloned the repository later, when it was merged to a newer master on github... I have an idea for a fix, will try. |
|
Performance test Ok. |
3 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Avoid overflow in parsing of DateTime values that will lead to negative unix timestamp in their timezone (for example,
1970-01-01 00:00:00in Moscow). Saturate to zero instead. This fixes #3470. This fixes #4172.