Skip to content

[wip] add fmtlib to 20.3#12407

Merged
akuzm merged 5 commits into20.3from
aku/fmtlib-20.3
Jul 14, 2020
Merged

[wip] add fmtlib to 20.3#12407
akuzm merged 5 commits into20.3from
aku/fmtlib-20.3

Conversation

@akuzm
Copy link
Copy Markdown
Contributor

@akuzm akuzm commented Jul 10, 2020

7db8edf added new exception messages that use fmtlib, and now we can't backport them. It would be simpler to add fmtlib to the back branch.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

@robot-clickhouse robot-clickhouse added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jul 10, 2020
@robot-clickhouse robot-clickhouse added the submodule changed At least one submodule changed in this PR. label Jul 10, 2020
@akuzm
Copy link
Copy Markdown
Contributor Author

akuzm commented Jul 14, 2020

The test failures seem to be the same as in 20.3 branch, I'll merge.

@akuzm akuzm merged commit e597dfa into 20.3 Jul 14, 2020
@akuzm akuzm deleted the aku/fmtlib-20.3 branch July 14, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants