Fix another Context-related segfault#12401
Merged
alexey-milovidov merged 1 commit intomasterfrom Jul 10, 2020
Merged
Conversation
robot-clickhouse
added
the
pr-bugfix
| max_parallel_streams += pipe.max_parallel_streams; | ||
| processors.insert(processors.end(), pipe.processors.begin(), pipe.processors.end()); | ||
|
|
||
| std::move(pipe.table_locks.begin(), pipe.table_locks.end(), std::back_inserter(table_locks)); |
Member
There was a problem hiding this comment.
The context of this code is not clear for me. Maybe add some comments?
Member
Author
There was a problem hiding this comment.
Comment is here. These shared pointers were lost when creating a Pipe from other Pipes.
alexey-milovidov
approved these changes
Jul 10, 2020
CurtizJ
pushed a commit
that referenced
this pull request
Jul 17, 2020
Fix another Context-related segfault (cherry picked from commit 7c2bd32)
CurtizJ
pushed a commit
that referenced
this pull request
Jul 19, 2020
Fix another Context-related segfault (cherry picked from commit 7c2bd32)
alexey-milovidov
added a commit
that referenced
this pull request
Jul 21, 2020
Fix another Context-related segfault (cherry picked from commit 7c2bd32)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed possible segfault if StorageMerge. Closes #12054