SHA256 add FixedString support#11878
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom Jun 23, 2020
Merged
Conversation
Member
|
Can you add relevant test cases? |
qoega
reviewed
Jun 23, 2020
Comment on lines
10
to
19
Member
There was a problem hiding this comment.
Suggested change
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT randomFixedString(20); | |
| INSERT INTO defaults SELECT s | |
| FROM generateRandom('s FixedString(20)', 1, 1, 1) | |
| LIMIT 20 |
Member
There was a problem hiding this comment.
randomFixedString is not stable between different calls. You can use predefined seed in generateRandom instead.
Collaborator
Author
There was a problem hiding this comment.
ok, i will change it.
Member
There was a problem hiding this comment.
Suggested change
| SELECT SHA256(s) FROM defaults; | |
| SELECT hex(SHA256(s)) FROM defaults; |
ucasfl
force-pushed
the
sha256
branch
2 times, most recently
from
6efb8d0 to
e72f943
Compare
alexey-milovidov
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add FixedString support in Hashing functions.
Detailed description / Documentation draft:
...
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.