Fix memory accounting via HTTP interface#11840
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom Jun 23, 2020
Merged
Fix memory accounting via HTTP interface#11840alexey-milovidov merged 5 commits intoClickHouse:masterfrom
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
Conversation
function perf_test()
{
time yes '127.1:8123/?wait_end_of_query=1' | head -n10000 | xargs -P10000 curl -s -d 'select 1' | grep -x -c 1
}
function server()
{
local limit=$1 && shift
clickhouse-server "$@" -- --max_server_memory_usage=$limit
}
perf_test:
- before this patch with 1G limit: succeed only ~800 queries
- after this patch with 1G limit: succeed ~8000 queries
- before this patch with 10G limit: succeed only ~3000 queries
- after this patch with 10G limit: succeed ~10000 queries
Fixes: ClickHouse#11153
Member
Broken in master @blinkov |
alexey-milovidov
approved these changes
Jun 21, 2020
Member
|
Something wrong with |
Member
Member
|
But the way, this test is also flaky but it fails only occasionally. |
Member
Author
I don't see the failure, but it may require some tuning |
azat
force-pushed
the
fix-http-memory-accounting
branch
4 times, most recently
from
e183f5a to
1b1b940
Compare
w/o the patch the test fails with, since it succeed only 512 queries.
azat
force-pushed
the
fix-http-memory-accounting
branch
from
1b1b940 to
9744c99
Compare
Member
Author
@alexey-milovidov Ok, found, and fixed and now only 01091_num_threads fails. |
Member
|
We have to ask @KochetovNicolai for help or maybe you can investigate? |
Actually there were two issues: - missing \n, so it picked the wrong query anway - no unique identifier, hence it may works incorrectly (and actually, event clickhouse-test script executes 'SELECT 1' query)
Member
Author
Interesting, fixed - 267a6c8 P.S. Hm, I didn't look that it does not fails on upstream, egh. |
Member
Author
|
Now tests passed |
abyss7
added a commit
that referenced
this pull request
Jun 25, 2020
…ceff19401bbc5b99b1716934b2827 Cherry pick #11840 to 20.5: Fix memory accounting via HTTP interface
alexey-milovidov
added a commit
that referenced
this pull request
Jul 7, 2020
…1968) Co-authored-by: robot-clickhouse <[email protected]> Co-authored-by: alexey-milovidov <[email protected]>
alesapin
pushed a commit
that referenced
this pull request
Jul 10, 2020
alesapin
added a commit
that referenced
this pull request
Jul 10, 2020
alesapin
pushed a commit
that referenced
this pull request
Jul 10, 2020
Fix memory accounting via HTTP interface (cherry picked from commit b447508)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix memory accounting via HTTP interface (can be significant with
wait_end_of_query=1)Fixes: #11153
Similar to: #11022