Fix crash in min(multiply(1)) with optimize_arithmetic_operations_in_aggregate_functions#11756
Merged
4ertus2 merged 2 commits intoClickHouse:masterfrom Jun 18, 2020
Merged
Conversation
4ertus2
changed the title
min(multiply(1)) with optimize_arithmetic_operations_in_aggregate_functions
azat
reviewed
Jun 18, 2020
4ertus2
approved these changes
Jun 18, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jun 20, 2020
alexey-milovidov
added a commit
that referenced
this pull request
Jun 20, 2020
…ptimize Fix 10% of bad code #11756
traceon
added a commit
to traceon/ClickHouse
that referenced
this pull request
Jun 20, 2020
* master: (114 commits) Update alter.md (ClickHouse#11823) Update PODArray.h Added a test for ClickHouse#6549 Update create.md Update create.md replacingmergetree translate into "替换合并树“ better (ClickHouse#11814) Whitespace Fix style Added a test Fix another 10% of bad code ClickHouse#11529 Update join.md (ClickHouse#11798) Update memory.md (ClickHouse#11800) Whitespace Check for tests with "fail" in their names Fix 10% of bad code ClickHouse#11756 Update PODArray.h avoid duplicate short system name adapt recent result as well [website] tune benchmark pages styling + add extra checks Added MSan suppression for Hyperscan ... # Conflicts: # src/Common/ErrorCodes.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixes crash in special generated queries when
optimize_arithmetic_operations_in_aggregate_functions = 1.Detailed description / Documentation draft:
requests of the following form: SELECT min(multiply(1)), SELECT max(multiply(1)), etc.
Closes #11741