Merged
Conversation
alexey-milovidov
approved these changes
Jun 13, 2020
| if (prewhere->remove_prewhere_column) | ||
| result.columns.erase(result.columns.begin() + prewhere_column_pos); | ||
| else | ||
| result.columns[prewhere_column_pos] = DataTypeUInt8().createColumnConst(result.num_rows, 1u)->convertToFullColumnIfConst(); |
Member
There was a problem hiding this comment.
Ok.
Just in case I want to make sure that we have run the search for
DataTypeUInt8().createColumn in all project files...
vitlibar
pushed a commit
that referenced
this pull request
Jun 19, 2020
Fix nullable prewhere type (cherry picked from commit f53da4d)
vitlibar
pushed a commit
that referenced
this pull request
Jun 20, 2020
Fix nullable prewhere type (cherry picked from commit f53da4d)
vitlibar
pushed a commit
that referenced
this pull request
Jun 20, 2020
Fix nullable prewhere type (cherry picked from commit f53da4d)
vitlibar
pushed a commit
that referenced
this pull request
Jun 22, 2020
…re-type" This reverts commit 592c9d2.
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 23, 2020
Fix nullable prewhere type (cherry picked from commit f53da4d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix rare crash caused by using
Nullablecolumn in prewhere condition. (Probably it is connected with #11572 somehow).@alesapin thanks for the test