Fix memory leak when exception is thrown in the middle of aggregation with -State functions#11496
Merged
alexey-milovidov merged 7 commits intomasterfrom Jun 8, 2020
Conversation
Member
Author
Unbundled build is accidentially broken by @abyss7. Fixed in master. |
Member
Author
|
Waiting for performance test... |
Member
Author
|
Performance test Ok. |
alexey-milovidov
deleted the
fix-aggregation-state-exception-safety-memory-leak
branch
vitlibar
pushed a commit
that referenced
this pull request
Jun 19, 2020
…tion-safety-memory-leak Fix memory leak when exception is thrown in the middle of aggregation with -State functions (cherry picked from commit 2bff9b4)
vitlibar
pushed a commit
that referenced
this pull request
Jun 19, 2020
…tion-safety-memory-leak Fix memory leak when exception is thrown in the middle of aggregation with -State functions (cherry picked from commit 2bff9b4)
vitlibar
pushed a commit
that referenced
this pull request
Jun 20, 2020
…tion-safety-memory-leak Fix memory leak when exception is thrown in the middle of aggregation with -State functions (cherry picked from commit 2bff9b4)
azat
added a commit
to azat/ClickHouse
that referenced
this pull request
Jul 5, 2022
…istic Sometimes if the 30 seconds is not enough for the query to fail (i.e. under TSan [1]), the error will be ignored and the test will fail. [1]: https://s3.amazonaws.com/clickhouse-test-reports/38748/d863f6ce1ece810c66ddf8bd89575825d3f2595f/stateless_tests__thread__actions__%5B2/3%5D.html Follow-up for: ClickHouse#11496 (cc @alexey-milovidov) Signed-off-by: Azat Khuzhin <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix memory leak when exception is thrown in the middle of aggregation with -State functions. This fixes #8995.