Skip to content

Merging #11453 (save history in clickhouse-client after every query)#11493

Merged
alexey-milovidov merged 8 commits intomasterfrom
kuskarov-fix_history_bugs
Jun 7, 2020
Merged

Merging #11453 (save history in clickhouse-client after every query)#11493
alexey-milovidov merged 8 commits intomasterfrom
kuskarov-fix_history_bugs

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
#11453

@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 7, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member Author

"Unbundled" build is broken accidentially by @abyss7
Already fixed in master.

@alexey-milovidov
Copy link
Copy Markdown
Member Author

"Arcadia" is broken because it contains copy-paste code. Will fix after merge.

@alexey-milovidov alexey-milovidov merged commit 16f0e3a into master Jun 7, 2020
@alexey-milovidov alexey-milovidov deleted the kuskarov-fix_history_bugs branch June 7, 2020 23:13
@abyss7
Copy link
Copy Markdown
Contributor

abyss7 commented Jun 7, 2020

"Unbundled" build is broken accidentially by @abyss7
Already fixed in master.

It looks more like it was already broken by @proller some time ago, when he added the logic for "unbundled" build and haven't even tested it with our docker image.

Also, unfortunately, we can't test the update to Dockerfile beforehand and I missed the broken build, when just added libhyperscan-dev for my upcoming PR - and that is my fault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants