Save history on every query in clickhouse-client#11453
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom Jun 7, 2020
kuskarov:fix_history_bugs
Merged
Save history on every query in clickhouse-client#11453alexey-milovidov merged 5 commits intoClickHouse:masterfrom kuskarov:fix_history_bugs
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
kuskarov:fix_history_bugs
Conversation
alexey-milovidov
added
can be tested
pr-improvement
Member
|
TODO: Replace |
Member
|
TODO: Add a test with |
alexey-milovidov
changed the title
alexey-milovidov
added a commit
that referenced
this pull request
Jun 7, 2020
Merging #11453 (save history in clickhouse-client after every query)
azat
reviewed
Jul 29, 2020
| { | ||
| // locking history file to prevent from inconsistent concurrent changes | ||
| bool locked = false; | ||
| if (flock(history_file_fd, LOCK_EX)) |
Member
There was a problem hiding this comment.
Actually replxx already has file locking 1, but only for history_save.
Should the client be that safe? I.e. care about race during history_load (looks a little bit overkill for this)
Footnotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now history file is updated after each query and there is no race condition if multiple clients use one history file. This fixes #9897.
Detailed description / Documentation draft:
Now history file is updated after each query. There is no race condition if multiple clients use one history file because before writing to file
flock()is called.