Skip to content

Remove structure lock on parts send#11354

Merged
alexey-milovidov merged 1 commit intomasterfrom
get_rid_of_lock_during_send
Jun 2, 2020
Merged

Remove structure lock on parts send#11354
alexey-milovidov merged 1 commit intomasterfrom
get_rid_of_lock_during_send

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jun 2, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Remove redundant lock during parts send in ReplicatedMergeTree.

@alesapin alesapin added pr-bugfix Pull request with bugfix, not backported by default no-docs-needed v20.1-no-backport labels Jun 2, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

test_ttl_move/test.py::test_concurrent_alter_with_ttl_move[concurrently_altering_ttl_mt-MergeTree()]

  • flaky test.

@alexey-milovidov alexey-milovidov merged commit ff72629 into master Jun 2, 2020
@alexey-milovidov alexey-milovidov deleted the get_rid_of_lock_during_send branch June 2, 2020 14:05
@alexey-milovidov alexey-milovidov self-assigned this Jun 2, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

Ok. I understand it in the following way:

  • parts are 100% immutable;
  • we don't need the lock if we read them, unless table is dropped;
  • table is not dropped during fetches because fetches are cancelled on drop and we wait for them to finish.

alesapin pushed a commit that referenced this pull request Jun 3, 2020
Remove structure lock on parts send

(cherry picked from commit ff72629)
alesapin pushed a commit that referenced this pull request Jun 3, 2020
Remove structure lock on parts send

(cherry picked from commit ff72629)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants