Skip to content

Stop merges before taking exclusive lock :(#11335

Merged
qoega merged 1 commit intomasterfrom
stop_merges_before_alter
Jun 2, 2020
Merged

Stop merges before taking exclusive lock :(#11335
qoega merged 1 commit intomasterfrom
stop_merges_before_alter

Conversation

@alesapin
Copy link
Copy Markdown
Member

@alesapin alesapin commented Jun 1, 2020

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Bug Fix

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now merges stopped before change metadata in ALTER queries.

@alesapin alesapin added pr-bugfix Pull request with bugfix, not backported by default v20.1-no-backport labels Jun 1, 2020
@qoega
Copy link
Copy Markdown
Member

qoega commented Jun 2, 2020

fails in checks are not relevant

@qoega qoega merged commit a101b17 into master Jun 2, 2020
@qoega qoega deleted the stop_merges_before_alter branch June 2, 2020 06:34
alesapin added a commit that referenced this pull request Jun 2, 2020
alesapin pushed a commit that referenced this pull request Jun 2, 2020
Stop merges before taking exclusive lock :(

(cherry picked from commit a101b17)
@alexey-milovidov
Copy link
Copy Markdown
Member

@qoega

The test

test_ttl_move/test.py::test_concurrent_alter_with_ttl_move[concurrently_altering_ttl_mt-MergeTree()]

should be reported.

@alexey-milovidov
Copy link
Copy Markdown
Member

And I don't understand why one of the builds failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-bugfix Pull request with bugfix, not backported by default

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants