Fix bug with Throttler and query speed estimation#11296
Merged
alexey-milovidov merged 15 commits intomasterfrom May 31, 2020
Merged
Fix bug with Throttler and query speed estimation#11296alexey-milovidov merged 15 commits intomasterfrom
alexey-milovidov merged 15 commits intomasterfrom
Conversation
Member
Author
Member
Author
|
The issue #6417 is not relevant to this bug but has to be checked again. |
Member
Author
Actually it's OOM on Sandbox server (misleading message). |
Member
Author
|
Note: this bugfix will be backported. But the only line that needs to be backported is: |
Member
Author
|
Here is the only commit that has to be backported: 9d39fc6 |
Member
|
@alexey-milovidov you should not add tags before bugfix is backported. Otherwise release script will think that you have already done it manually. |
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix bug with Throttler and query speed estimation (cherry picked from commit 97d9f21)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix bug with Throttler and query speed estimation (cherry picked from commit 97d9f21)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fix bug with Throttler and query speed estimation (cherry picked from commit 97d9f21)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix bug when query speed estimation can be incorrect and the limit of
min_execution_speedmay not work or work incorrectly if the query is throttled bymax_network_bandwidth,max_execution_speedorprioritysettings. Change the default value oftimeout_before_checking_execution_speedto non-zero, because otherwise the settingsmin_execution_speedandmax_execution_speedhave no effect. This fixes #11297. This fixes #5732. This fixes #6228. Usability improvement: avoid concatenation of exception message with progress bar inclickhouse-client.