Skip to content

Use proper versions in Arcadia build.#11255

Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
zlobober:proper_versions_in_arcadia
May 29, 2020
Merged

Use proper versions in Arcadia build.#11255
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
zlobober:proper_versions_in_arcadia

Conversation

@zlobober
Copy link
Copy Markdown
Contributor

@zlobober zlobober commented May 28, 2020 •
edited
Loading

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Refer to internal CLICKHOUSE-4844 issue for details.

Short summary:

  • autogenerated part moved out of version.cmake to make it re-usable when building with ya make;
  • set replaced with SET (cmake recognizes both macro spellings, while ya make only the latter one);
  • release_lib.sh updated accordingly to the new location (somebody from CH team should check if it works!);
  • separate ya.make.versions.inc is introduced; it may be included by Arcadia projects.

@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 28, 2020
@alexey-milovidov alexey-milovidov self-assigned this May 28, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member

alexey-milovidov commented May 28, 2020

somebody from CH team should check if it works!

Looks Ok, we will check on next release.

@alexey-milovidov alexey-milovidov merged commit 04bdffd into ClickHouse:master May 29, 2020
alesapin pushed a commit that referenced this pull request Jun 3, 2020
@alexey-milovidov @alesapin
Merge pull request #11255 from zlobober/proper_versions_in_arcadia
ed83f8d 
Use proper versions in Arcadia build.

(cherry picked from commit 04bdffd)
alesapin pushed a commit that referenced this pull request Jun 3, 2020
@alexey-milovidov @alesapin
Merge pull request #11255 from zlobober/proper_versions_in_arcadia
fa3d0a3 
Use proper versions in Arcadia build.

(cherry picked from commit 04bdffd)
alesapin pushed a commit that referenced this pull request Jun 4, 2020
@alexey-milovidov @alesapin
Merge pull request #11255 from zlobober/proper_versions_in_arcadia
b4c65df 
Use proper versions in Arcadia build.

(cherry picked from commit 04bdffd)
(cherry picked from commit ed83f8d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexey-milovidov alexey-milovidov alexey-milovidov approved these changes

Assignees

@alexey-milovidov alexey-milovidov

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zlobober @alexey-milovidov @blinkov