Cache-dictionary getString() bugfix#11233
Merged
nikitamikhaylov merged 2 commits intoClickHouse:masterfrom May 29, 2020
Merged
Conversation
nikitamikhaylov
added
pr-must-backport
akuzm
approved these changes
May 28, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Cache-dictionary getString() bugfix (cherry picked from commit 9233997)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Cache-dictionary getString() bugfix (cherry picked from commit 9233997)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed a bug when cache-dictionary could return default value instead of normal (when there are only expired keys). This affects only string fields.
Need to be backported with #10337 in 20.3 and maybe in 20.4. (It is marked as feature, but actually it is a bugfix. Because without upper bound on cell lifetime dictionary could return extremely old value and it is abnormal. )