Fixed S3 globbing which could fail in case of more than 1000 keys and some backends#11179
Merged
alexey-milovidov merged 3 commits intoClickHouse:masterfrom May 25, 2020
excitoon-favorites:s3globfix
Merged
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends#11179alexey-milovidov merged 3 commits intoClickHouse:masterfrom excitoon-favorites:s3globfix
alexey-milovidov merged 3 commits intoClickHouse:masterfrom
excitoon-favorites:s3globfix
Conversation
| assert expected_err_msg in instance.query_and_get_error(query) | ||
|
|
||
|
|
||
| def test_s3_glob_scheherazade(cluster): |
Member
There was a problem hiding this comment.
Need a comment with cultural references. Not everyone is familiar what is "scheherazade". Wikipedia Ok.
alexey-milovidov
approved these changes
May 25, 2020
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends (cherry picked from commit d4acd1a)
KochetovNicolai
pushed a commit
that referenced
this pull request
Jun 8, 2020
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends (cherry picked from commit d4acd1a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed S3 globbing which could fail in case of more than 1000 keys and some backends.