Do not reserve extra threads after max threads optimization for simple queries#11114
Merged
KochetovNicolai merged 4 commits intoClickHouse:masterfrom May 25, 2020
Merged
Conversation
Member
Author
|
Will undraft it once the test failures will be investigated |
…e queries Before this patch pipeline.setMaxThreads() was called with 0 (since streams.size() == 0, while pipes.size() == 1), which leads that pipeline.getMaxThreads() returns max_streams. While this threads were not used, they were reserved, which should not happens either.
Fixes: 01245_limit_infinite_sources
azat
force-pushed
the
max_threads-simple-query-optimization-fix
branch
from
01ba6ea to
8c69245
Compare
Member
Author
|
@KochetovNicolai can you take a look on PR?
The test |
KochetovNicolai
approved these changes
May 25, 2020
KochetovNicolai
added a commit
that referenced
this pull request
Jun 8, 2020
…tion-fix Do not reserve extra threads after max threads optimization for simple queries (cherry picked from commit c83014b)
KochetovNicolai
added a commit
that referenced
this pull request
Jun 8, 2020
…tion-fix Do not reserve extra threads after max threads optimization for simple queries (cherry picked from commit c83014b)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix excessive reserving of threads for simple queries (optimization for reducing the number of threads, which was partly broken after changes in pipeline).
Do not reserve extra threads after max threads optimization for simple queries
Cc: @KochetovNicolai
Refs: #11104