Fix memory leak in registerDiskS3#11074
Merged
alexey-milovidov merged 2 commits intoClickHouse:masterfrom May 21, 2020
Merged
Conversation
Member
|
@Jokser Maybe test with unavailable S3 worth adding? (that triggers the initial issue) |
Member
|
+1, let's add a test that can reproduce the leak before this change (no need to validate it, just let's add this test case). |
Member
|
Thie leak issue can be detected with |
Member
@alesapin AFAIU it will trigger the issue only when s3 (minio) will not be available, am I missing something? For example this build does not have this patch and successfully passes (And the problem that the leak happens only on abnormal shutdown) |
nikitamikhaylov
pushed a commit
to nikitamikhaylov/ClickHouse
that referenced
this pull request
May 23, 2020
…er-disk-s3 Fix memory leak in registerDiskS3 (cherry picked from commit 4a237fa)
nikitamikhaylov
added a commit
that referenced
this pull request
May 23, 2020
* Merge pull request #10910 from filimonov/kafka_drop_hang_fix Fix for the hang during deletion of engine=Kafka (cherry picked from commit 0fd0711) * Merge pull request #10986 from ClickHouse/try-fix-use-after-free-mergetree Try to fix use-after-free error in MergeTree (cherry picked from commit 073dc2e) * Merge pull request #11048 from filimonov/kafka_missed_data_during_drop Fixes the potential missed data during termination of Kafka engine table (cherry picked from commit b82c633) * Merge pull request #11109 from ClickHouse/less_verbose_logging Less verbose logging in mutation finalization task (cherry picked from commit 1906762) * Merge pull request #11074 from Jokser/memory-leak-in-register-disk-s3 Fix memory leak in registerDiskS3 (cherry picked from commit 4a237fa) * Merge pull request #11038 from Enmk/parseDateTime64BestEffort_fix Fixed parseDateTime64BestEffort implementation (cherry picked from commit 5a0f356) Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fixed memory leak in registerDiskS3
Detailed description / Documentation draft:
Memory leak in registerDiskS3 that was found here #11029 (comment) is fixed.
Improved S3 proxy resolver error handling and usability