Implement IDisk interface for HDFS#11058
Merged
kssenii merged 55 commits intoClickHouse:masterfrom May 26, 2021
Merged
Conversation
kssenii
changed the title
Member
|
@Jokser, I moved some common part of disks s3 / hdfs into separate interface (only part related to metadata and clickhouse side methods), please take a look. |
Contributor
Member
|
@Jokser, hi, please don't forget to take a look. |
Jokser
suggested changes
May 18, 2021
Contributor
Jokser
left a comment
Jokser
left a comment
There was a problem hiding this comment.
Overall DiskHDFS looks very similiar to DiskS3.
I see only 3 things that have different implementations:
- Create ReadBuffer
- Create WriteBuffer
- Remove file
I think that common part including (Read/Write) IndirectBuffers can be extracted to DiskRemote.
Jokser
suggested changes
May 24, 2021
Contributor
Jokser
left a comment
Jokser
left a comment
There was a problem hiding this comment.
Overall looks good. Only minor issues remain.
Jokser
approved these changes
May 26, 2021
Contributor
|
Internal documentation ticket: DOCSUP-11416 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add support for VFS over HDFS.