Merged
Conversation
…e.g. VARCHAR(255)) and ignore them completely.
blinkov
added
the
pr-not-for-changelog
Contributor
|
Please add a functional test for this to |
4ertus2
reviewed
Jun 4, 2020
| " Instead there is a column with the following structure: " + column->dumpStructure(), | ||
| ErrorCodes::ILLEGAL_TYPE_OF_ARGUMENT); | ||
|
|
||
| Settings set; |
Contributor
There was a problem hiding this comment.
It does not work this way. You should get settings with context.getSettingsRef() that allowed in create(const Context &). So you need extract needed setting there.
Member
|
FYI This pull request is not merged. |
Merged
Contributor
|
Closed in favor of #11733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Detailed description / Documentation draft:
Now cast kept nullability. Add cast_keep_nullable setting