Fix for the hang during deletion of engine=Kafka#10910
Merged
alexey-milovidov merged 5 commits intoClickHouse:masterfrom May 17, 2020
Merged
Fix for the hang during deletion of engine=Kafka#10910alexey-milovidov merged 5 commits intoClickHouse:masterfrom
alexey-milovidov merged 5 commits intoClickHouse:masterfrom
Conversation
azat
reviewed
May 14, 2020
azat
reviewed
May 14, 2020
azat
reviewed
May 14, 2020
azat
approved these changes
May 14, 2020
Member
azat
left a comment
azat
left a comment
There was a problem hiding this comment.
The test passed in my env multiple times
Contributor
Author
|
Integration test failure is relevant (will fix that) |
azat
approved these changes
May 15, 2020
Member
azat
left a comment
azat
left a comment
There was a problem hiding this comment.
After latest changes test (test_storage_kafka/test.py::test_kafka_consumer_hang) passed in my env too (multiple times), plus now code looks cleaner!
Member
|
Stress test shows use-after-free, need to investigate. |
Member
This was referenced May 21, 2020
nikitamikhaylov
pushed a commit
to nikitamikhaylov/ClickHouse
that referenced
this pull request
May 22, 2020
Fix for the hang during deletion of engine=Kafka (cherry picked from commit 0fd0711)
nikitamikhaylov
added a commit
that referenced
this pull request
May 23, 2020
* Merge pull request #10910 from filimonov/kafka_drop_hang_fix Fix for the hang during deletion of engine=Kafka (cherry picked from commit 0fd0711) * Merge pull request #10986 from ClickHouse/try-fix-use-after-free-mergetree Try to fix use-after-free error in MergeTree (cherry picked from commit 073dc2e) * Merge pull request #11048 from filimonov/kafka_missed_data_during_drop Fixes the potential missed data during termination of Kafka engine table (cherry picked from commit b82c633) * Merge pull request #11109 from ClickHouse/less_verbose_logging Less verbose logging in mutation finalization task (cherry picked from commit 1906762) * Merge pull request #11074 from Jokser/memory-leak-in-register-disk-s3 Fix memory leak in registerDiskS3 (cherry picked from commit 4a237fa) * Merge pull request #11038 from Enmk/parseDateTime64BestEffort_fix Fixed parseDateTime64BestEffort implementation (cherry picked from commit 5a0f356) Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]>
filimonov
pushed a commit
to filimonov/ClickHouse
that referenced
this pull request
Jun 8, 2020
Fix for the hang during deletion of engine=Kafka (cherry picked from commit 0fd0711)
filimonov
pushed a commit
to filimonov/ClickHouse
that referenced
this pull request
Jun 8, 2020
Fix for the hang during deletion of engine=Kafka (cherry picked from commit 0fd0711)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix for the hang which was happening sometimes during DROP of table engine=Kafka (or during server restarts).
Detailed description / Documentation draft:
In general, it looks like the shutdown sequence was a bit incorrect, and librdkafka is very restrictive in that part.
Kudos to @azat for test case (#10656)
Fixes #7260 #10740