Fix ENOENT exception on current_batch.txt in DirectoryMonitor#10865
Merged
alesapin merged 1 commit intoClickHouse:masterfrom May 15, 2020
Merged
Fix ENOENT exception on current_batch.txt in DirectoryMonitor#10865alesapin merged 1 commit intoClickHouse:masterfrom
alesapin merged 1 commit intoClickHouse:masterfrom
Conversation
current_batch.txt will not exist if there was no send, this is the case when all batches that was pending has been marked as pending.
blinkov
added
the
pr-not-for-changelog
Member
|
Is there a way to add a test for this scenario(all batches pending) |
Member
Author
|
Looks like to tiny for the integration test (and there was no harm, just a noise in logs) |
alesapin
approved these changes
May 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
current_batch.txt will not exist if there was no send, this is the case
when all batches that was pending has been marked as pending.