Skip to content

Fix test with obvious race condition#10820

Merged
alexey-milovidov merged 1 commit intomasterfrom
split-build-smoke-test-fix
May 11, 2020
Merged

Fix test with obvious race condition#10820
alexey-milovidov merged 1 commit intomasterfrom
split-build-smoke-test-fix

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Build/Testing/Packaging Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix obvious race condition in "Split build smoke test" check.

@alexey-milovidov alexey-milovidov requested a review from alesapin May 11, 2020 17:34
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Docker image will be rebuilt after merge.

@blinkov blinkov added the pr-build Pull request with build/testing/packaging improvement label May 11, 2020
@alexey-milovidov
Copy link
Copy Markdown
Member Author

Docker build has been tested manually:

$ docker build .
Sending build context to Docker daemon  3.584kB
Step 1/3 : FROM yandex/clickhouse-binary-builder
latest: Pulling from yandex/clickhouse-binary-builder
cbdc015de259: Pull complete 
35f8707632bb: Pull complete 
6b786d087f83: Pull complete 
31fb3cd05fdd: Pull complete 
8f35df5bd252: Pull complete 
8e8cb78da735: Pull complete 
ce74ac149756: Pull complete 
545b4b95ee47: Pull complete 
b27c251b2376: Pull complete 
e31a70d9d52e: Pull complete 
7e843c8bba18: Pull complete 
1c03d8303ade: Pull complete 
836abec5cd6c: Pull complete 
4b91c444d3ac: Pull complete 
2682a074b26e: Pull complete 
023261c4e9f6: Pull complete 
50c2a872eeac: Pull complete 
e695b9efabee: Pull complete 
88337e97ccea: Pull complete 
9b133e4c1d62: Pull complete 
Digest: sha256:ee72407bf13986687a60abf7cbd0d2819cc11e1645f2c544213e05740a330cbd
Status: Downloaded newer image for yandex/clickhouse-binary-builder:latest
 ---> 3c837fd5602e
Step 2/3 : COPY run.sh /run.sh
 ---> 3c139aa8bb6e
Step 3/3 : CMD /run.sh
 ---> Running in 345655eca33d
Removing intermediate container 345655eca33d
 ---> 1b4f79c46a87
Successfully built 1b4f79c46a87

@alexey-milovidov
Copy link
Copy Markdown
Member Author

Correctness of the script was checked manually:

+ LD_LIBRARY_PATH=/unpacked
+ /unpacked/clickhouse-client --query 'select '\''OK'\'''
./run.sh: line 14: /var/log/clickhouse-server/clientstderr.log: No such file or directory
+ [[ 99 == 100 ]]
+ for i in {1..100}
+ sleep 1
+ LD_LIBRARY_PATH=/unpacked
+ /unpacked/clickhouse-client --query 'select '\''OK'\'''
./run.sh: line 14: /var/log/clickhouse-server/clientstderr.log: No such file or directory
+ [[ 100 == 100 ]]
+ echo FAIL
FAIL

@alexey-milovidov alexey-milovidov merged commit 71fbc33 into master May 11, 2020
@alexey-milovidov alexey-milovidov deleted the split-build-smoke-test-fix branch May 11, 2020 17:39
@alexey-milovidov alexey-milovidov mentioned this pull request May 11, 2020
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-build Pull request with build/testing/packaging improvement testing Special issue with list of bugs found by CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants