Skip to content

Fix flacky test for query profiler#10782

Merged
alexey-milovidov merged 1 commit intomasterfrom
fix-test-query-profiler
May 10, 2020
Merged

Fix flacky test for query profiler#10782
alexey-milovidov merged 1 commit intomasterfrom
fix-test-query-profiler

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Non-significant (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
It may fail for the following reasons:

  • the function to generate numbers may be inlined and does not appear as a symbol (this was noticed in release build with clang-10 but it looks like not the case for gcc);
  • the query may process too quicky but profiler interval was set to just 10 times per second;
  • if we execute test multiple times a second, ORDER BY event_time may return non-deterministic result.

@alexey-milovidov alexey-milovidov added the testing Special issue with list of bugs found by CI label May 10, 2020
@alexey-milovidov alexey-milovidov mentioned this pull request May 10, 2020
11 tasks
@blinkov blinkov added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 10, 2020
@alexey-milovidov alexey-milovidov merged commit 9fbf23b into master May 10, 2020
@alexey-milovidov alexey-milovidov deleted the fix-test-query-profiler branch May 10, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-docs-needed pr-not-for-changelog This PR should not be mentioned in the changelog testing Special issue with list of bugs found by CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants