Fix nullptr dereference in StorageBuffer#10641
Merged
alexey-milovidov merged 1 commit intomasterfrom May 3, 2020
Merged
Conversation
Member
Author
|
It looks like this: People may mistakenly attribute this issue to ThreadFuzzer. |
qoega
added
no-docs-needed
pr-bugfix
abyss7
pushed a commit
to abyss7/ClickHouse
that referenced
this pull request
May 18, 2020
…llptr-dereference Fix nullptr dereference in StorageBuffer (cherry picked from commit 884c2aa)
nikitamikhaylov
pushed a commit
that referenced
this pull request
May 23, 2020
* Merge pull request #10268 from ClickHouse/max-rows-to-sort Added failing tests about "max_rows_to_sort" setting. (cherry picked from commit f7b1263) * Merge pull request #10486 from azat/dist-send-on-INSERT Fix distributed send that are scheduled by INSERT query (cherry picked from commit ddc8416) * Merge pull request #10516 from azat/dist-GROUP_BY-sharding_key-fixes Disable GROUP BY sharding_key optimization by default (and fix for WITH ROLLUP/CUBE/TOTALS) (cherry picked from commit 33d491e) * Merge pull request #10560 from Enmk/DateTime64_fixes Fixed comparing DateTime64 in WHERE against String value (cherry picked from commit 67efc7f) * Merge pull request #10563 from azat/SELECT-ALIAS-CAST Fix SELECT of column ALIAS which default expression type different from column type (cherry picked from commit 15e38c8) * Merge pull request #10569 from zhang2014/fix/ISSUES-10551 ISSUES-10551 add backward compatibility for create bloom filter index (cherry picked from commit db4c235) * Merge pull request #10587 from vitlibar/database-with-dictionary-init-in-constructor Move initialization of DatabaseWithDictionaries to constructor. (cherry picked from commit 2528e72) * Merge pull request #10588 from excitoon-favorites/fixmutations Fixed handling condition variable for synchronous mutations (cherry picked from commit 992e589) * Merge pull request #10611 from azat/optimize_skip_unused_shards-LowCardinality Fix optimize_skip_unused_shards with LowCardinality (cherry picked from commit 229f666) * Merge pull request #10641 from ClickHouse/storage-buffer-nullptr-dereference Fix nullptr dereference in StorageBuffer (cherry picked from commit 884c2aa) * Merge pull request #10659 from ClickHouse/fix_multiple_simultaneous_alters Fix alter-mutations assignment (cherry picked from commit 5eebe8c) * Merge pull request #10711 from ClickHouse/h3-range-check Range check in function h3EdgeAngle (cherry picked from commit d0b61f9) * Merge pull request #10741 from hczhcz/patch-0422 Fix OrNull and OrDefault (cherry picked from commit 699ef4f) * Merge pull request #10757 from ClickHouse/fix-parallel-mv Fix parallel MV (cherry picked from commit ef1c7da) * Merge pull request #10791 from oandrew/key-condition-source-type Use src_type for conversion in KeyCondition (cherry picked from commit a133389) * Merge pull request #10798 from ClickHouse/fix-date-lut-msan-ubsan Fix UBSan and MSan report in DateLUT (cherry picked from commit a2f220f) * Merge pull request #10821 from ClickHouse/fix-odbc-bridge-clickhouse Fix the issue with ODBC bridge and identifier_quoting_style = None #7984 (cherry picked from commit 5115ac2) * Merge pull request #10826 from azat/block-sort-fix Fix columns order after Block::sortColumns() (cherry picked from commit 75607db) * Merge pull request #10834 from ClickHouse/fix-msan-failure-cache-dictionary Fix MSan failure in cache dictionary (cherry picked from commit 6cba2da) * Merge pull request #10847 from ClickHouse/fix_alter_rename_and_constraints Fix constraints after column rename (cherry picked from commit 377ef65) * Merge pull request #10849 from ClickHouse/fix_optimize_and_alter_hangs Fix mutations and OPTIMIZE hangs when replica becomes inactive (cherry picked from commit 623b2e5) * Merge pull request #10859 from ClickHouse/fix_watch_livelock_with_database_atomic Fix livelock with WATCH queries and DatabaseAtomic (cherry picked from commit a47bf09) * Merge pull request #10870 from azat/fix-SIGSEGV-in-hash-table-for-string Fix SIGSEGV in StringHashTable (if such key does not exist) (cherry picked from commit 0433d9c) * Destructive IAggregateFunction::insertResultInto and ColumnAggregateFunction::convertToValues (#10890) * Destructive IAggregateFunction::insertResultInto and ColumnAggregateFunction::convertToValues * Try fix build. * Try fix build. * Fix build. * Make convertToValues static. * fix build. * Remove const casts. * Added comment. * Fix build. * Fix build. * Add test. * Fix test. (cherry picked from commit f653058) * Merge pull request #10895 from ClickHouse/fix_multiple_renames Fix error in multiple rename commands in a single query. (cherry picked from commit be4037a) * Merge pull request #10920 from ClickHouse/fix-notNullIn-with-null Fix not null in with null (cherry picked from commit 1bceb48) * Merge pull request #10940 from azat/dist-send-partially-written-read-fix Avoid sending partially written files by the DistributedBlockOutputStream (cherry picked from commit 0d76091) * Merge pull request #10952 from ClickHouse/fix-distributed-queries-incompatibility-19.16-20.1 Fix incompatibility of two-level aggregation between 19.16 and 20.1 (cherry picked from commit c957154) * Merge pull request #10964 from ObjatieGroba/bugfix_raw_column_size Fix incorrect Column byte size (cherry picked from commit b6b1947) * Merge pull request #10968 from ClickHouse/fix_database_atomic_terminate_called Fix exception from destructor in DatabaseAtomic (cherry picked from commit 103f66e) * Merge pull request #10970 from ClickHouse/try-fix-use-after-free-mergetree Try to fix use-after-free error in MergeTree (cherry picked from commit 421eb6d) * Merge pull request #10980 from azat/database-atomic-fixes Database atomic fixes (cherry picked from commit 6f1d522) Co-authored-by: alexey-milovidov <[email protected]> Co-authored-by: Vitaly Baranov <[email protected]> Co-authored-by: alesapin <[email protected]> Co-authored-by: Anton Popov <[email protected]> Co-authored-by: tavplubix <[email protected]> Co-authored-by: Nikolai Kochetov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix nullptr dereference in StorageBuffer if server was shutdown before table startup.
Detailed description / Documentation draft:
This bug was introduced in #10315. The bug was first noticed and reported by @qoega.