Conversation
blinkov
added
the
pr-other
zhang2014
reviewed
Apr 28, 2020
| if (capturingNamedQueryParam(analyze_receive_params, regex)) | ||
| return addFiltersFromConfig(new HandlingRuleHTTPHandlerFactory<PredefinedQueryHandler>( | ||
| server, std::move(analyze_receive_params), std::move(predefined_query), std::move(regex), | ||
| std::move(headers_name_with_regex)), configuration, config_prefix); |
Contributor
There was a problem hiding this comment.
CompiledRegexPtr is shared multiple handlers. it's thread safe?
Member
Author
There was a problem hiding this comment.
Using compiled RE2 from multiple threads is safe. However, we also have re2_st with disabled internal mutex and there are some mutable fields in RE2, so I'm not sure about safety of const methods of re2_st::RE2 version. I will replace it with ordinary re2, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Merging #7572