Moved files from tests directory#10484
Conversation
tests/README.md
Outdated
These configs are used in Docker images for tests. |
|
FYI the tests for external models are not automated. It's time to convert them to integration tests. |
I see only one way how this configs are used in docker images. And proller@ showed me before that this files are used in There is no documentation about I consider more straightforward way to depend on configuration in tests and include them explicitly in tests. Currently if we just need to add new config for test we have to
And environment that is used to run stateless/stateful tests manually differs from CI. I believe we should make something as simple as queries directory that is used in tests.
If we do so, our tests would be more portable, and we would be able to re-run test with older clickhouse binaries. TLDR:
|
|
Ok, let's make all builds successfull and merge. PS. I don't care about |
|
Let's merge with master. |
|
Something wrong with build scripts: |
|
Please open a new PR. |
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Moved files from tests directory
Detailed description / Documentation draft:
By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.
If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.