Auto distributed_group_by_no_merge on GROUP BY sharding key#10341
Auto distributed_group_by_no_merge on GROUP BY sharding key#10341alexey-milovidov merged 6 commits intoClickHouse:masterfrom
Conversation
|
What I'm wondering before looking into code... is that Let's check that. |
Indeed, but there is |
|
What if there are other operations that require merging, e.g. |
534a365 to
034152a
Compare
|
Ok. The code becomes complicated and bug-prone but still acceptable. Maybe we can solve the task by introducing another QueryProcessingStage: WithMergeableStateAfterAggregation (it means that aggregate functions were calculated and finalized) and process it inside InterpreterSelectQuery? (we can experiment in a separate PR) |
Yeah, I was just "experimenting" |
034152a to
35eec0a
Compare
35eec0a to
93d049f
Compare
…p_by_no_merge optimization
…ted::canForceGroupByNoMerge()
Decided to address this separately (to avoid polluting this patch set, since I guess there will be some corner cases that I will forget about) |
|
Ok. |
@alexey-milovidov #10373 implements this |
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Auto distributed_group_by_no_merge on GROUP BY sharding key (if
optimize_skip_unused_shardsis set)Fixes: #332