Proper dictionary timeouts. #10337
Merged
alexey-milovidov merged 1 commit intoClickHouse:masterfrom Apr 18, 2020
Merged
Conversation
nikitamikhaylov
added
pr-feature
alexey-milovidov
approved these changes
Apr 18, 2020
nikitamikhaylov
pushed a commit
that referenced
this pull request
Jun 8, 2020
…outs Proper dictionary timeouts. (cherry picked from commit 391165d)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now ClickHouse controls timeouts of dictionary sources on its side. Two new settings added to cache dictionary configuration:
strict_max_lifetime_seconds, which ismax_lifetimeby default andquery_wait_timeout_milliseconds, which is one minute by default. The first settings is also useful withallow_read_expired_keyssettings (to forbid reading very expired keys).