Add test: MergeTree deserialization of combined subcolumn with mixed l#101280
Open
clickgapai wants to merge 1 commit intoClickHouse:masterfrom
Open
Add test: MergeTree deserialization of combined subcolumn with mixed l#101280clickgapai wants to merge 1 commit intoClickHouse:masterfrom
clickgapai wants to merge 1 commit intoClickHouse:masterfrom
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found via ClickGap automated review. Please close or comment if this is incorrect or needs adjustment.
Adds test coverage for 1 untested code path(s), found during automated review of PR #98788.
1. MergeTree deserialization of combined subcolumn with mixed literal and sub-object values untested
src/DataTypes/Serializations/SerializationObjectCombinedPath.cpp:186Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Not applicable — test-only change.
Documentation entry for user-facing changes
Found during review of PR #98788.