Skip to content

tests: better fix for 03706_statistics_preserve_checksums_on_mutations#100896

Merged
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/03706_statistics_preserve_checksums_on_mutations
Mar 27, 2026
Merged

tests: better fix for 03706_statistics_preserve_checksums_on_mutations#100896
azat merged 1 commit intoClickHouse:masterfrom
azat:tests/03706_statistics_preserve_checksums_on_mutations

Conversation

@azat
Copy link
Copy Markdown
Member

@azat azat commented Mar 27, 2026

The previous bot attempt (#100772) was to set serialization_info_version='basic', while this is OK, it is not transparent what was the problem.

Let's instead set map_serialization_version='basic', map_serialization_version_for_zero_level_parts='basic', since those was causes the difference:

File: .server/data/default/mt/all_1_1_0_2/serialization.json
{"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"nullable":1,"string":0},"version":1}

File: .server/data/default/mt/all_1_1_0/serialization.json
{"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"map":1,"nullable":1,"string":0},"version":1}

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

The previous bot attempt was to set serialization_info_version='basic',
while this is OK, it is not transparent what was the problem.

Let's instead set map_serialization_version='basic',
map_serialization_version_for_zero_level_parts='basic', since those was
causes the difference:

    File: .server/data/default/mt/all_1_1_0_2/serialization.json
    {"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"nullable":1,"string":0},"version":1}

    File: .server/data/default/mt/all_1_1_0/serialization.json
    {"columns":[],"propagate_types_serialization_versions_to_nested_types":true,"types_serialization_versions":{"map":1,"nullable":1,"string":0},"version":1}
@clickhouse-gh
Copy link
Copy Markdown
Contributor

clickhouse-gh bot commented Mar 27, 2026

Workflow [PR], commit [ee5b389]

Summary:

job_name test_name status info comment
Stateless tests (amd_debug, parallel) failure
02967_parallel_replicas_joins_and_analyzer FAIL cidb, issue

AI Review

Summary

This PR updates the stateless test 03706_statistics_preserve_checksums_on_mutations to pin Map serialization settings (map_serialization_version and map_serialization_version_for_zero_level_parts) instead of serialization_info_version, making the test setup more explicit about the source of checksum differences in serialization.json. I did not find blockers or major issues in the changed scope.

ClickHouse Rules
Item Status Notes
Deletion logging
Serialization versioning
Core-area scrutiny
No test removal
Experimental gate
No magic constants
Backward compatibility
SettingsChangesHistory.cpp
PR metadata quality
Safe rollout
Compilation time
Final Verdict
  • Status: ✅ Approve

@clickhouse-gh clickhouse-gh bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 27, 2026
@Algunenano Algunenano self-assigned this Mar 27, 2026
@nikitamikhaylov
Copy link
Copy Markdown
Member

Interesting how we can use it to make the cat better. FYI @pufit

@azat azat enabled auto-merge March 27, 2026 13:07
@azat azat added this pull request to the merge queue Mar 27, 2026
Merged via the queue into ClickHouse:master with commit d1c68a3 Mar 27, 2026
151 of 153 checks passed
@azat azat deleted the tests/03706_statistics_preserve_checksums_on_mutations branch March 27, 2026 16:38
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 27, 2026
@robot-ch-test-poll robot-ch-test-poll added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Mar 27, 2026
Desel72 pushed a commit to Desel72/ClickHouse that referenced this pull request Mar 30, 2026
…_preserve_checksums_on_mutations

tests: better fix for 03706_statistics_preserve_checksums_on_mutations
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo v26.3-must-backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants